Skip to content

Update fr_fr.json#1171

Open
squeletoon27 wants to merge 1 commit into
mrh0:1.21.1from
squeletoon27:patch-2
Open

Update fr_fr.json#1171
squeletoon27 wants to merge 1 commit into
mrh0:1.21.1from
squeletoon27:patch-2

Conversation

@squeletoon27

@squeletoon27 squeletoon27 commented Jun 3, 2026

Copy link
Copy Markdown

Pull Request Checklist

Please review and complete all items before submitting your pull request:

  • [/] I have thoroughly tested the changes and verified they work as expected.
  • [/] The code follows the coding standards and best practices of the project.
  • [/] I have reviewed the changes for potential security or performance issues.

MIT License Confirmation

  • [/] I confirm that all code included in this PR is compatible with the MIT License.
  • [/] I understand and accept that, by submitting this pull request, all contributions are permanently licensed under the MIT License, and I waive any rights to revoke or change the license in the future.

Description

Following the latest update, the Electrum Amulet has had it's purpose changed from a Speed and Luck bonus at low health to randomly charging FE-chargeable items while giving the player the "Shocked" effect. The main pupose of this PR/Commit is to update the french dub in this regard.

Also changed the fr translation of "Shocked" effect from "Foudroyé" (thunderstruck) to "Choc électrique" (electric shock), which seems clearer to me (because it could be misinterpreted as being an effect dealt only by thunder, for example).

Last but not least, it seems that the "Shocked" effect description in-game doesn't load it's translation, as it appears in English when viewed in Just Enough Effect Descriptions, but that issue might be on Just Enough Effect Descriptions's end.

Related Issues: Electrum amulet description - Shocked effect misinterpretation

Closes #

Following the latest update, the Electrum Amulet has had it's purpose changed from a Speed and Luck bonus at low health to randomly charging FE-chargeable items while giving the player the "Shocked" effect. The main pupose of this PR/Commit is to update the french dub in this regard.

Also changed the fr translation of "Shocked" effect from "Foudroyé" (thunderstruck) to "Choc électrique" (electric shock), which seems clearer to me (because it could be misinterpreted as being an effect dealt only by thunder, for example).

Last but not least, it seems that the "Shocked" effect description in-game doesn't load it's translation, as it appears in English when viewed in Just Enough Effect Descriptions, but that issue might be on JEED's end.
"item.createaddition.electrum_amulet": "Amulette en électrum",
"item.createaddition.electrum_amulet.tooltip": "AMULETTE_EN_ÉLECTRUM",
"item.createaddition.electrum_amulet.tooltip.summary": "Lorsque _vous êtes au plus bas_, tenir cette _amulette_ dans votre poche vous donne l'impression que votre _chance_ va tourner.",
"item.createaddition.electrum_amulet.tooltip.summary": "Cette _amulette_ a un effet _\"foudroyant⚡\"_ sur les objets chargeables en Énergie Forge (Forge Energy ou FE) ! Tiens la dans ta main et elle chargera les objets dans ton autre main par à-coups..",

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is the main issue: Given the new version changed the purpose of the Electrum amulet, the description on the left red side is no longer accurate (it was for the former, but not the new one).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants